linux-kernel - Re: [PATCH] i2c: designware: Fix bogus sda_hold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8F61EF18-169A-4FB5-B9C7-9A2ACD4C92B4@linaro.org>
Date:   Mon, 22 May 2017 08:02:29 +0200
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Jan Kiszka <jan.kiszka@...mens.com>
Cc:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        mika.westerberg@...ux.intel.com, wsa@...-dreams.de,
        linux-i2c@...r.kernel.org,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: designware: Fix bogus sda_hold_time due to uninitialized vars



> On 22 May 2017, at 07:46, Jan Kiszka <jan.kiszka@...mens.com> wrote:
> 
> We need to initializes those variables to 0 for platforms that do not
> provide ACPI parameters. Otherwise, we set sda_hold_time to random
> values, breaking e.g. Galileo and IOT2000 boards.
> 
> Fixes: 9d6408433019 ("i2c: designware: don't infer timings described by ACPI from clock rate")
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

> ---
> 
> Affects 4.12-rc2.
> 
> drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 6283b99d2b17..d1263b82d646 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -94,9 +94,9 @@ static void dw_i2c_acpi_params(struct platform_device *pdev, char method[],
> static int dw_i2c_acpi_configure(struct platform_device *pdev)
> {
>    struct dw_i2c_dev *dev = platform_get_drvdata(pdev);
> +    u32 ss_ht = 0, fp_ht = 0, hs_ht = 0, fs_ht = 0;
>    acpi_handle handle = ACPI_HANDLE(&pdev->dev);
>    const struct acpi_device_id *id;
> -    u32 ss_ht, fp_ht, hs_ht, fs_ht;
>    struct acpi_device *adev;
>    const char *uid;
>