linux-kernel - Re: struct i2c_mux_pinctrl_platform_data for the i2c-mux-pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71dc13f9-f723-fb4b-a101-f7be8caacf1c@wwwdotorg.org>
Date:   Mon, 22 May 2017 09:51:46 -0600
From:   Stephen Warren <swarren@...dotorg.org>
To:     Peter Rosin <peda@...ntia.se>, Stephen Warren <swarren@...dia.com>
Cc:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: struct i2c_mux_pinctrl_platform_data for the i2c-mux-pinctrl
 driver

On 05/22/2017 02:24 AM, Peter Rosin wrote:
> Hi Stephen,
> 
> I was looking at the i2c-mux-pinctrl driver and noticed that it has
> code to feed it platform data from C code. There has never been any
> in-kernel users of this interface and I would like to remove it. I
> wonder if you added it way back when just because the i2c-mux-gpio
> driver have such an interface or if, to your knowledge, any external
> platform exists that depends on this?
> 
> I.e. I'm talking about removing include/linux/i2c-mux-pinctrl.h and
> the code supporting it in the driver, thus only allowing devicetree
> as source for the platform data.

I'm not aware of any in- or out-of-tree users of that structure/feature.

I added it because at the time I wrote that driver, it was common place 
to support both DT-based and platform-data-based 
instantiation/configuration of devices, so I did the same. If you're 
removing pdata-based configuration, it would make sense to do a blanket 
removal across the entire I2C subsystem (and other subsystems too) I 
suspect, but that's LinusW's call in the end.