lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 May 2017 12:06:25 -0400 (EDT) From: David Miller <davem@...emloft.net> To: jarod@...hat.com Cc: linux-kernel@...r.kernel.org, j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net, netdev@...r.kernel.org Subject: Re: [PATCH net v2] bonding: fix accounting of active ports in 3ad From: Jarod Wilson <jarod@...hat.com> Date: Fri, 19 May 2017 19:43:45 -0400 > As of 7bb11dc9f59d and 0622cab0341c, bond slaves in a 3ad bond are not > removed from the aggregator when they are down, and the active slave count > is NOT equal to number of ports in the aggregator, but rather the number > of ports in the aggregator that are still enabled. The sysfs spew for > bonding_show_ad_num_ports() has a comment that says "Show number of active > 802.3ad ports.", but it's currently showing total number of ports, both > active and inactive. Remedy it by using the same logic introduced in > 0622cab0341c in __bond_3ad_get_active_agg_info(), so sysfs, procfs and > netlink all report the number of active ports. Note that this means that > IFLA_BOND_AD_INFO_NUM_PORTS really means NUM_ACTIVE_PORTS instead of > NUM_PORTS, and thus perhaps should be renamed for clarity. > > Lightly tested on a dual i40e lacp bond, simulating link downs with an ip > link set dev <slave2> down, was able to produce the state where I could > see both in the same aggregator, but a number of ports count of 1. ... > Signed-off-by: Jarod Wilson <jarod@...hat.com> > --- > v2: fix incorrect git sha reference, add more testing data Applied and queued up for -stable, thanks Jarod!
Powered by blists - more mailing lists