linux-kernel - Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VesAMbxViEDDa7sTkufDKJgnX23y2L=SM968rFSsFtiDQ@mail.gmail.com>
Date:   Mon, 22 May 2017 19:37:54 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Luis Oliveira <Luis.Oliveira@...opsys.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c@...r.kernel.org, devicetree <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ramiro Oliveira <Ramiro.Oliveira@...opsys.com>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions

On Mon, May 22, 2017 at 5:32 PM, Luis Oliveira
<Luis.Oliveira@...opsys.com> wrote:
> On 08-May-17 17:53, Andy Shevchenko wrote:
>> On Mon, 2017-05-08 at 11:37 +0100, Luis Oliveira wrote:

>>> +            enabled, slave_activity, raw_stat, stat);
>>> +
>>
>>> +    if (slave_activity) {
>>> +            if (stat & DW_IC_INTR_RD_REQ) {
>>
>> Looking into next condition (stat & DW_IC_INTR_RX_DONE) I would
>> exchange these lines
>>
>
> By order? I don't think I understood your point. Please elaborate a little more.

if (stat & DW_IC_INTR_RD_REQ) {
  if (slave_activity) {

And perhaps refactor function a bit.

-- 
With Best Regards,
Andy Shevchenko