lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 22 May 2017 20:18:21 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Technical Support <techsupport@...mtech-fastcom.com>
Cc:     Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        linux-gpio <linux-gpio@...r.kernel.org>
Subject: Re: gpio-exar: Why filtering out Commtech devices?

On 2017-05-22 18:24, Jan Kiszka wrote:
> On 2017-05-22 17:17, Technical Support wrote:
>> Hello,
>>
>> The Exar MPIO pins are used by our device driver to control features of
>> the line driver and can't be used as GPIO pins.  I agree, the condition
>> can be moved to 8250_exar prior to a platform device being created for
>> the gpio_exar driver.
>>
> 
> Thanks a lot for the feedback! I will send a refactoring patch.

Hmm, are you possibly talking about PCI device with the IDs 0x2, 0x4,
0xa, 0xb (4222PCI335, 4224PCI335, 2324PCI335, 2328PCI335), because those
actually set the GPIOs for apparent internal reasons. However,
0x20..0x22 (4222PCIE, 4224PCIE, 4228PCIE) already share setup_gpio() via
pci_xr17v35x_setup(), and that looks different.

I'm also asking again because we just changed the default MPIO settings
for the latter to all inputs. If you depended on them to be all outputs
and 0, we may have broken something.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

Powered by blists - more mailing lists