linux-kernel - Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfMaUKTMYt1S7-BMLWzP68vJyfqmsDZxEBW5cUhKsTNBA@mail.gmail.com>
Date:   Mon, 22 May 2017 21:37:30 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Jan Kiszka <jan.kiszka@...mens.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sascha Weisenberger <sascha.weisenberger@...mens.com>
Subject: Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table
 for retrieving frequency

On Mon, May 22, 2017 at 9:23 PM, Lee Jones <lee.jones@...aro.org> wrote:
> On Mon, 22 May 2017, Andy Shevchenko wrote:
>> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@...mens.com> wrote:
>> > On 2017-05-22 19:36, Andy Shevchenko wrote:

>> > Then let's leave the decision up to the maintainer.
>>
>> Lee, just for your convenience I'm repeating myself here:
>>
>> I do not like this series at all since it tries to solve non-existing
>> issue in over-engineering way.
>>
>> If you on opposite side I will be happy to help reviewing it.
>
> New code looks cleaner and appears to use an already defined API.

Got your point.
Jan, care to resend  (an updated?) version?

-- 
With Best Regards,
Andy Shevchenko