linux-kernel - Re: [PATCH V1] leds: pca955x: Correct I2C Functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <860beb3d-67e5-2e01-c430-897759633ec9@gmail.com>
Date:   Mon, 22 May 2017 21:02:29 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Tin Huynh <tnhuynh@....com>, Richard Purdie <rpurdie@...ys.net>,
        Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Loc Ho <lho@....com>, Phong Vo <pvo@....com>,
        Thang Nguyen <tqnguyen@....com>, patches@....com
Subject: Re: [PATCH V1] leds: pca955x: Correct I2C Functionality

Hi Tin,

On 05/22/2017 11:19 AM, Tin Huynh wrote:
> The driver checks an incorrect flag of functionality of adapter.
> When a driver requires i2c_smbus_read_byte_data and
> i2c_smbus_write_byte_data, it should check I2C_FUNC_SMBUS_BYTE_DATA
> instead I2C_FUNC_I2C.
> This patch fixes the problem.
> 
> Signed-off-by: Tin Huynh <tnhuynh@....com>
> ---
>  drivers/leds/leds-pca955x.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> index 78a7ce8..9a87311 100644
> --- a/drivers/leds/leds-pca955x.c
> +++ b/drivers/leds/leds-pca955x.c
> @@ -285,7 +285,7 @@ static int pca955x_probe(struct i2c_client *client,
>  			"slave address 0x%02x\n",
>  			client->name, chip->bits, client->addr);
>  
> -	if (!i2c_check_functionality(adapter, I2C_FUNC_I2C))
> +	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
>  		return -EIO;
>  
>  	if (pdata) {
> 

Applied to the fixes-for-4.12rc3 branch of linux-leds.git, thanks.

-- 
Best regards,
Jacek Anaszewski