linux-kernel - Re: [PATCH] kexec/kdump: Minor Documentation updates for arm64 and Image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 May 2017 12:35:04 +0530
From:   Pratyush Anand <panand@...hat.com>
To:     Bharat Bhushan <bharat.bhushan@....com>,
        AKASHI Takahiro <takahiro.akashi@...aro.org>,
        Dave Young <dyoung@...hat.com>,
        "bhe@...hat.com" <bhe@...hat.com>,
        "vgoyal@...hat.com" <vgoyal@...hat.com>,
        "corbet@....net" <corbet@....net>,
        "kexec@...ts.infradead.org" <kexec@...ts.infradead.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kexec/kdump: Minor Documentation updates for arm64 and
 Image



On Monday 22 May 2017 12:19 PM, Bharat Bhushan wrote:
>> On Friday 19 May 2017 09:15 AM, AKASHI Takahiro wrote:
>>>>> +to load dump-capture kernel.
>>>>> +
>>>>> +   kexec -p <dump-capture-kernel-Image> \
>>>>> +   --initrd=<initrd-for-dump-capture-kernel> \
>>>>> +   --append="root=<root-dev> <arch-specific-options>"
>>>> For uncompressed Image, dtb is not necessary?
>>> Just for clarification, dtb is optional for both vmlinux and Image on
>>> arm64. (This means you can specify it if you want.) But this is also
>>> true for initrd and append(command line) to some extent.
>>
>> Yes, I agree.
>
> Should I mention "-dtb" also for "Image"?

No,I think it is fine.

This documentation is representing a typical use case and so above changes is 
OK for me. I think,your v2 is fine.

~Pratyush

>
> Also do we need to mention that it is optional somewhere in this document? I do not see "optional" is mentioned for other parameters and architecture.
>
> Does this looks ok:
>
> 	" -dtb=<optional-dtb-for-dump-capture-kernel> \"
>
> Thanks
> -Bharat
>
>>>
>>> More precisely, whether these parameters are optional or not will
>>> depend on architectures, not formats, I believe.
>>
>> May be not architecture, rather a distro environment.
>>
>> For example, we should be able to work without --initrd for any arch if kernel
>> has been compiled by configuring CONFG_INITRAMFS_SOURCE.
>>
>> ~Pratyush
>