linux-kernel - RE: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0401MB1856C0396AE7608FF2FC8CF1ECF80@VI1PR0401MB1856.eurprd04.prod.outlook.com>
Date:   Mon, 22 May 2017 07:12:39 +0000
From:   Laurentiu Tudor <laurentiu.tudor@....com>
To:     Marc Zyngier <marc.zyngier@....com>,
        Matthias Brugger <matthias.bgg@...il.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "stuyoder@...il.com" <stuyoder@...il.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "Ruxandra Ioana Radulescu" <ruxandra.radulescu@....com>,
        Roy Pledge <roy.pledge@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "agraf@...e.de" <agraf@...e.de>,
        Catalin Horghidan <catalin.horghidan@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        Leo Li <leoyang.li@....com>,
        Bharat Bhushan <bharat.bhushan@....com>,
        Jason Cooper <jason@...edaemon.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: RE: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

Hi Marc,

> -----Original Message-----
> From: Marc Zyngier [mailto:marc.zyngier@....com]
> Sent: Saturday, May 20, 2017 9:43 AM
> To: Matthias Brugger <matthias.bgg@...il.com>
> Cc: Laurentiu Tudor <laurentiu.tudor@....com>; gregkh@...uxfoundation.org;
> stuyoder@...il.com; devel@...verdev.osuosl.org; arnd@...db.de; Ruxandra
> Ioana Radulescu <ruxandra.radulescu@....com>; Stuart Yoder
> <stuart.yoder@....com>; Roy Pledge <roy.pledge@....com>; linux-
> kernel@...r.kernel.org; agraf@...e.de; Catalin Horghidan
> <catalin.horghidan@....com>; Ioana Ciornei <ioana.ciornei@....com>;
> Thomas Gleixner <tglx@...utronix.de>; Leo Li <leoyang.li@....com>; Bharat
> Bhushan <bharat.bhushan@....com>; Jason Cooper <jason@...edaemon.net>;
> linux-arm-kernel@...ts.infradead.org; Rob Herring <robh+dt@...nel.org>
> Subject: Re: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging
> Importance: High
> 
> On Fri, May 19 2017 at 02:41:43 PM, Matthias Brugger
> <matthias.bgg@...il.com> wrote:
> > On 19/05/17 15:13, laurentiu.tudor@....com wrote:
> >> From: Stuart Yoder <stuart.yoder@....com>
> >>
> >> Move the source files out of staging into their final locations:
> >>    -include files in drivers/staging/fsl-mc/include go to include/linux/fsl
> >>    -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
> >
> > This driver has as compatible "arm,gic-v3-its". I wonder if this is
> > correct and if it should be moved like this out of staging.
> 
> This is no different from the way we handle *any* bus that uses the
> GICv3 ITS as an MSI controller. Each bus provides its glue code that latches onto
> the ITS node, and calls into the generic code.
> 
> Now, when it comes to moving this out of staging, here is my concern:
> There is mention of a userspace tool (restool) used to control the HW. Where is
> this tool? Where is the user ABI documented?

The tool is published here:

https://github.com/qoriq-open-source/restool

There are two ways of configuring the mc-bus:
 - a static one, through a FDT based configuration file (we call it DPL), documented in the refman linked below, chapter 22.
 - a dynamic one, using this restool utility.
Please note the usage of restool is optional.

The reference manual documenting the ABI can be found here (registration required):

https://freescale.sdlproducts.com/LiveContent/content/en-US/QorIQ_SDK/GUID-53BEBDD8-1A5E-4DD0-8354-A9647AD35755

Click on the DPAA2 user manual link.

We're also working on publishing the docs on github so that they're more accessible.

---
Thanks & Best Regards, Laurentiu