lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 May 2017 16:50:38 -0300 From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com> To: SF Markus Elfring <elfring@...rs.sourceforge.net> Cc: linux-sctp@...r.kernel.org, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Neil Horman <nhorman@...driver.com>, Vlad Yasevich <vyasevich@...il.com>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init() On Mon, May 22, 2017 at 09:46:21PM +0200, SF Markus Elfring wrote: > >> +++ b/net/sctp/protocol.c > >> @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) > >> if (!sctp_ep_hashtable) { > >> - pr_err("Failed endpoint_hash alloc\n"); > > > > Okay but then why not also delete the one a few lines below this one: > > if (!sctp_port_hashtable) { > > pr_err("Failed bind hash alloc\n"); > > status = -ENOMEM; > > goto err_bhash_alloc; > > } > > Seems the same pattern to me. > > > >> status = -ENOMEM; > >> goto err_ehash_alloc; > >> } > > How do you think about to remove the other error message in another > update step if a consensus would be achieved in such a direction > for this software module? Fine by me. Regards, Marcelo
Powered by blists - more mailing lists