linux-kernel - Re: [PATCH 4/4] input: tsc2007: move header file out of I2C realm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170522205416.GA12016@dtor-ws>
Date:   Mon, 22 May 2017 13:54:16 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>, linux-sh@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 4/4] input: tsc2007: move header file out of I2C realm

On Mon, May 22, 2017 at 08:41:05AM +0100, Lee Jones wrote:
> On Sun, 21 May 2017, Wolfram Sang wrote:
> 
> > include/linux/i2c is not for client devices. Move the header file to a
> > more appropriate location.
> > 
> > Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
> > ---
> >  arch/sh/boards/mach-ecovec24/setup.c     | 2 +-
> >  drivers/input/touchscreen/tsc2007_core.c | 2 +-
> >  drivers/mfd/timberdale.c                 | 2 +-
> 
> Acked-by: Lee Jones <lee.jones@...aro.org>
> 
> >  include/linux/{i2c => input}/tsc2007.h   | 2 +-
> >  4 files changed, 4 insertions(+), 4 deletions(-)
> >  rename include/linux/{i2c => input}/tsc2007.h (95%)

This should really go into include/linux/platform_data/, not into
input/, for the same reason you are moving it out of i2c. I'd also like
to get rid of platform data for tsc2007 altogether...

I guess I'll take it (moving to platform_data/) so I can work on generic
properties...

Thanks.

-- 
Dmitry