[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170522144501.2d02b5799e07167dc5aecf3e@linux-foundation.org>
Date: Mon, 22 May 2017 14:45:01 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Matthias Kaehlcke <mka@...omium.org>
Cc: David Rientjes <rientjes@...gle.com>,
Christoph Lameter <cl@...ux.com>,
Pekka Enberg <penberg@...nel.org>,
Joonsoo Kim <iamjoonsoo.kim@....com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for
NUMA systems
On Mon, 22 May 2017 13:56:21 -0700 Matthias Kaehlcke <mka@...omium.org> wrote:
> El Mon, May 22, 2017 at 01:39:26PM -0700 David Rientjes ha dit:
>
> > On Fri, 19 May 2017, Matthias Kaehlcke wrote:
> >
> > > The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef
> > > block fixes the following warning when building with clang:
> > >
> > > mm/slub.c:1246:20: error: unused function 'kmalloc_large_node_hook'
> > > [-Werror,-Wunused-function]
> > >
> >
> > Is clang not inlining kmalloc_large_node_hook() for some reason? I don't
> > think this should ever warn on gcc.
>
> clang warns about unused static inline functions outside of header
> files, in difference to gcc.
I wish it wouldn't. These patches just add clutter.
Powered by blists - more mailing lists