linux-kernel - Re: [PATCH] mmc: renesas-sdhi: export renesas_sdhi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170523053155.GD25840@verge.net.au>
Date:   Tue, 23 May 2017 07:31:55 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Chris Brandt <chris.brandt@...esas.com>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: renesas-sdhi: export renesas_sdhi_probe

On Mon, May 22, 2017 at 03:33:08PM +0200, Arnd Bergmann wrote:
> We now build the sdhi driver in separate modules, which means we
> have to export the symbols that are called from another module:
> 
> ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
> ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
> 
> Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")

Sorry for messing this up and thanks for the fix.

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/mmc/host/renesas_sdhi_core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 846ee1a8e5a6..fa6c188e0327 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -638,6 +638,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
>  eprobe:
>  	return ret;
>  }
> +EXPORT_SYMBOL_GPL(renesas_sdhi_probe);
>  
>  int renesas_sdhi_remove(struct platform_device *pdev)
>  {
> @@ -648,3 +649,4 @@ int renesas_sdhi_remove(struct platform_device *pdev)
>  
>  	return 0;
>  }
> +EXPORT_SYMBOL_GPL(renesas_sdhi_remove);
> -- 
> 2.9.0
>