[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <812482107.237697.1495570315919@email.1und1.de>
Date: Tue, 23 May 2017 22:11:55 +0200 (CEST)
From: Stefan Wahren <stefan.wahren@...e.com>
To: Paul Gortmaker <paul.gortmaker@...driver.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Scott Branden <sbranden@...adcom.com>,
Ray Jui <rjui@...adcom.com>, Eric Anholt <eric@...olt.net>,
bcm-kernel-feedback-list@...adcom.com, linux-gpio@...r.kernel.org,
Florian Fainelli <f.fainelli@...il.com>,
linux-rpi-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Jon Mason <jonmason@...adcom.com>,
Sherman Yin <syin@...adcom.com>
Subject: Re: [PATCH 3/3] pinctrl: bcm: clean up modular vs. non-modular
distinctions
> Paul Gortmaker <paul.gortmaker@...driver.com> hat am 22. Mai 2017 um 22:56 geschrieben:
>
>
> Fixups here tend to be more of a conglomerate of some of the other
> repeated/systematic ones we've seen in the earlier pinctrl cleanups.
>
> We remove module.h from code that isn't doing anything modular at
> all; if they have __init sections, then replace it with init.h
>
> One driver has a .remove that would be dispatched on module_exit,
> and as that code is essentially orphaned, so we remove it. In case
> anyone was previously doing the (pointless) unbind to get to that
> function, we disable unbind for this one driver as well.
>
> A couple bool drivers (hence non-modular) are converted over to
> to builtin_platform_driver().
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> Cc: Eric Anholt <eric@...olt.net>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Jon Mason <jonmason@...adcom.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Ray Jui <rjui@...adcom.com>
> Cc: Scott Branden <sbranden@...adcom.com>
> Cc: Stefan Wahren <stefan.wahren@...e.com>
> Cc: Sherman Yin <syin@...adcom.com>
> Cc: bcm-kernel-feedback-list@...adcom.com
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-rpi-kernel@...ts.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
> drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 16 ++++++++--------
> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 20 +++-----------------
Tested-by: Stefan Wahren <stefan.wahren@...e.com>
for pinctrl-bcm2835
Powered by blists - more mailing lists