linux-kernel - Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170523072615.r4widzjc6apwxpwb@dell>
Date:   Tue, 23 May 2017 08:26:15 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Zhang Rui <rui.zhang@...el.com>
Cc:     sathyanarayanan.kuppuswamy@...ux.intel.com, gnurou@...il.com,
        linus.walleij@...aro.org, edubezval@...il.com,
        dvhart@...radead.org, andy@...radead.org,
        linux-gpio@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        sathyaosid@...il.com
Subject: Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level
 PMIC thermal irq

On Tue, 23 May 2017, Zhang Rui wrote:

> On Fri, 2017-04-14 at 16:25 -0700,
> sathyanarayanan.kuppuswamy@...ux.intel.com wrote:
> > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.in
> > tel.com>
> > 
> > PMIC mfd driver only exports first level irq for thermal device.
> > But currently we are reading the irqs from the second level irq
> > chip, So this patch fixes this issue by adding support to use
> > first level PMIC thermal irq.
> > 
> > Signed-off-by: Kuppuswamy Sathyanarayanan
> > <sathyanarayanan.kuppuswamy@...ux.intel.com>
> 
> Acked-by: Zhang Rui <rui.zhang@...el.com>

I think this is the last Ack.

Please collect them all and re-submit the set so I can pick it up.

> > ---
> >  drivers/thermal/intel_bxt_pmic_thermal.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Changes since v1:
> >  * None
> > 
> > diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c
> > b/drivers/thermal/intel_bxt_pmic_thermal.c
> > index 0f19a39..ef6b322 100644
> > --- a/drivers/thermal/intel_bxt_pmic_thermal.c
> > +++ b/drivers/thermal/intel_bxt_pmic_thermal.c
> > @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct
> > platform_device *pdev)
> >  	}
> >  
> >  	regmap = pmic->regmap;
> > -	regmap_irq_chip = pmic->irq_chip_data_level2;
> > +	regmap_irq_chip = pmic->irq_chip_data;
> >  
> >  	pmic_irq_count = 0;
> >  	while ((irq = platform_get_irq(pdev, pmic_irq_count)) !=
> > -ENXIO) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog