linux-kernel - Re: [PATCH v4 2/2] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKMK7uFvCDHB_a0X3SRcneaRzXN=LUNLw4JHGFsX+rhZ_xk_cQ@mail.gmail.com>
Date:   Tue, 23 May 2017 09:38:38 +0200
From:   Daniel Vetter <daniel.vetter@...ll.ch>
To:     Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:     Robert Foss <robert.foss@...labora.com>,
        Liviu Dudau <liviu.dudau@....com>,
        Brian Starkey <brian.starkey@....com>,
        Mali DP Maintainers <malidp@...s.arm.com>,
        Dave Airlie <airlied@...ux.ie>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Boris BREZILLON <boris.brezillon@...e-electrons.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        "Nikula, Jani" <jani.nikula@...ux.intel.com>,
        Sean Paul <seanpaul@...omium.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "Clark, Rob" <robdclark@...il.com>,
        Ben Skeggs <bskeggs@...hat.com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        VMware Graphics <linux-graphics-maintainer@...are.com>,
        Sinclair Yeh <syeh@...are.com>,
        Thomas Hellstrom <thellstrom@...are.com>,
        Archit Taneja <architt@...eaurora.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        intel-gfx <intel-gfx@...ts.freedesktop.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        freedreno@...ts.freedesktop.org,
        Nouveau Dev <nouveau@...ts.freedesktop.org>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Emil Velikov <emil.l.velikov@...il.com>,
        Kristian Høgsberg <hoegsberg@...il.com>
Subject: Re: [PATCH v4 2/2] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI

On Mon, May 22, 2017 at 6:09 PM, Ville Syrjälä
<ville.syrjala@...ux.intel.com> wrote:
>> +/*
>> + * DRM_MODE_REFLECT_<axis>
>> + *
>> + * Signals that the contents of a drm plane is reflected in the <axis> axis,
>> + * in the same way as mirroring.
>
> That's not what I was after. We're still missing the information about
> the order in which reflection and rotation happens. Also does "in the
> axis" mean the same thing as "along the axis" and not "across the axis"?
> /me thinks the old text was better

There's already a pretty lengthy kernel-doc in drm_blend.c which is
trying to explain all this. Duplicating all these things here is not
all that awesome imo. Can we perhaps instead reference the text in
drm_blend.c and make sure that is the one true source of truth?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch