linux-kernel - Re: [PATCH] scsi: hisi_sas: add null check before indirect pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93be1808-c4f8-dbb4-f928-ac3a1f5f474c@huawei.com>
Date:   Tue, 23 May 2017 08:43:57 +0100
From:   John Garry <john.garry@...wei.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: hisi_sas: add null check before indirect pointer
 dereference

On 22/05/2017 19:00, Gustavo A. R. Silva wrote:
> Add null check before indirectly dereferencing pointer task->lldd_task
> in statement u32 tag = slot->idx;
>

I don't think that this is a valid scenario, but protecting against a 
possible NULL dereference is prudent. Thanks

> Addresses-Coverity-ID: 1373843
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Reviewed-by: John Garry <john.garry@...wei.com>