linux-kernel - Re: [PATCH v2 0/3] mtd: sharpslpart partition parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAQYJAv-8wH=UuEvOtubimw1bLTiPEwdgJTdhiYQ_z_PYd+keA@mail.gmail.com>
Date:   Tue, 23 May 2017 11:11:36 +0200
From:   Andrea Adami <andrea.adami@...il.com>
To:     linux-mtd@...ts.infradead.org
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] mtd: sharpslpart partition parser

On Sat, Apr 22, 2017 at 1:20 PM, Andrea Adami <andrea.adami@...il.com> wrote:
> This patchset introduces a simple partition parser for the Sharp SL
> Series PXA handhelds. More details in the commit text.
>
> I have set in cc the ARM PXA maintainers because this is the MTD part of
> a planned wider patchset cleaning the Zaurus board files.
>
> Changelog:
> v1 initial import of 2.4 sources [1]
> v2 refactor applying many suggested fixes [2]
>
> [1] https://github.com/LinuxPDA/Sharp_FTL_2.4.20
> [2] https://github.com/LinuxPDA/linux/commits/sharpslpart_v2
>
> Andrea Adami (3):
>   mtd: sharpsl: add sharpslpart MTD partition parser
>   mtd: nand: sharpsl.c: prefer sharpslpart MTD partition parser
>   mtd: nand: tmio_nand.c: prefer sharpslpart MTD partition parser
>
>  drivers/mtd/Kconfig          |   8 ++
>  drivers/mtd/Makefile         |   2 +
>  drivers/mtd/nand/sharpsl.c   |   4 +-
>  drivers/mtd/nand/tmio_nand.c |   4 +-
>  drivers/mtd/sharpsl_ftl.c    | 219 +++++++++++++++++++++++++++++++++++++++++++
>  drivers/mtd/sharpsl_ftl.h    |  34 +++++++
>  drivers/mtd/sharpslpart.c    | 132 ++++++++++++++++++++++++++
>  7 files changed, 401 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/mtd/sharpsl_ftl.c
>  create mode 100644 drivers/mtd/sharpsl_ftl.h
>  create mode 100644 drivers/mtd/sharpslpart.c
>
> --
> 2.7.4
>

Hello,

I'd be thankful for a second review after the big changes from v1
which was just a proof of concept.
As for the memory management, it totally mimics the other parsers.

The patch has been backported to 4.4 [1] and up to 3.10 [2] with
minimal changes to module init/exit:
since linux 4.5 (commit b8f70ba mtd: kill off MTD partition parser
boilerplate) we use module_mtd_part_parser().

With this parser we have finally a single linux-as bootloader kernel
covering the 4 Zaurus pxa 27x devices (repartitioned or not).

Thanks in advance
Andrea

[1] http://cgit.openembedded.org/meta-handheld/tree/recipes-kernel/linux/linux-handheld-4.4/sharpslpart/0001-mtd-sharpsl-add-sharpslpart-MTD-partition-parser.patch
[2] https://github.com/greguu/linux-3.10.y-c3x00-f2fs-kexec-r0/commit/f087900fbd778cce642a8e24e7351a0d814bb9a7