linux-kernel - Re: staging: sm750fb: Replace CamelCase variable names with underscores

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 May 2017 03:49:19 -0700
From:   Joe Perches <joe@...ches.com>
To:     Richa Jha <richaj@...c.in>, gregkh@...uxfoundation.org
Cc:     sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
        linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: staging: sm750fb: Replace CamelCase variable names with
 underscores

On Tue, 2017-05-23 at 11:01 +0530, Richa Jha wrote:
>     Replace CamelCase variable names with underscores to comply with
>     the standard kernel coding style

Better would be to remove the hungarian prefixes too

> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
[]
> @@ -55,7 +55,7 @@ static unsigned int get_mxclk_freq(void)
>  static void set_chip_clock(unsigned int frequency)
>  {
>  	struct pll_value pll;
> -	unsigned int ulActualMxClk;
> +	unsigned int ul_actual_max_clk;

	unsigned int actual_max_clk;

etc...