linux-kernel - Re: [PATCH 12/12] arm64: dts: hikey960: add LED nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 May 2017 20:07:26 +0800
From:   Guodong Xu <guodong.xu@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     "xuwei (O)" <xuwei5@...ilicon.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        "Chenfeng (puck)" <puck.chen@...ilicon.com>,
        Xuejiancheng <xuejiancheng@...ilicon.com>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 12/12] arm64: dts: hikey960: add LED nodes

On Tue, May 23, 2017 at 8:48 AM, Rob Herring <robh@...nel.org> wrote:
> On Wed, May 17, 2017 at 04:37:45PM +0800, Guodong Xu wrote:
>> HiKey960 has four user LEDs, and two special purpose LEDs: WiFi and BT
>> respectively.
>>
>> All of them are implemented as GPIO.
>>
>> Signed-off-by: Guodong Xu <guodong.xu@...aro.org>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 48 +++++++++++++++++++++++
>>  1 file changed, 48 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> index 6de86c0..4839885 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
>> @@ -48,6 +48,54 @@
>>                               linux,code = <KEY_POWER>;
>>                       };
>>               };
>> +
>> +             leds {
>
> This too should move out of the soc node.

Thanks, Rob. I will fix these.

-Guodong

>
>> +                     compatible = "gpio-leds";
>> +                     status = "disabled";
>> +                     user_led1 {
>> +                             label = "user_led1";
>> +                             /* gpio_150_user_led1 */
>> +                             gpios = <&gpio18 6 0>;
>> +                             linux,default-trigger = "heartbeat";
>> +                     };
>> +
>> +                     user_led2 {
>> +                             label = "user_led2";
>> +                             /* gpio_151_user_led2 */
>> +                             gpios = <&gpio18 7 0>;
>> +                             linux,default-trigger = "mmc0";
>> +                     };
>> +
>> +                     user_led3 {
>> +                             label = "user_led3";
>> +                             /* gpio_189_user_led3 */
>> +                             gpios = <&gpio23 5 0>;
>> +                             default-state = "off";
>> +                     };
>> +
>> +                     user_led4 {
>> +                             label = "user_led4";
>> +                             /* gpio_190_user_led4 */
>> +                             gpios = <&gpio23 6 0>;
>> +                             linux,default-trigger = "cpu0";
>> +                     };
>> +
>> +                     wlan_active_led {
>> +                             label = "wifi_active";
>> +                             /* gpio_205_wifi_active */
>> +                             gpios = <&gpio25 5 0>;
>> +                             linux,default-trigger = "phy0tx";
>> +                             default-state = "off";
>> +                     };
>> +
>> +                     bt_active_led {
>> +                             label = "bt_active";
>> +                             gpios = <&gpio25 7 0>;
>> +                             /* gpio_207_user_led1 */
>> +                             linux,default-trigger = "hci0rx";
>> +                             default-state = "off";
>> +                     };
>> +             };
>>       };
>>  };
>>
>> --
>> 2.10.2
>>