linux-kernel - Re: [PATCH 1/3] mfd: lp87565: Add lp87565 PMIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 May 2017 17:51:12 +0530
From:   Keerthy <j-keerthy@...com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     <broonie@...nel.org>, <robh+dt@...nel.org>, <t-kristo@...com>,
        <tony@...mide.com>, <mark.rutland@....com>,
        <linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 1/3] mfd: lp87565: Add lp87565 PMIC support



On Tuesday 23 May 2017 03:41 PM, Keerthy wrote:
> 
> 
> On Tuesday 23 May 2017 02:15 PM, Lee Jones wrote:
>> On Tue, 23 May 2017, Keerthy wrote:
>>> On Tuesday 23 May 2017 12:27 PM, Lee Jones wrote:
>>>> On Tue, 23 May 2017, Keerthy wrote:
>>>>> On Monday 22 May 2017 11:18 PM, Lee Jones wrote:
>>>>>> On Fri, 19 May 2017, Keerthy wrote:
>>>>>>
>>>>>>> The LP87565 chip is a power management IC for Portable Navigation Systems
>>>>>>> and Tablet Computing devices. It contains the following components:
>>>>>>>
>>>>>>>         - Configurable Bucks(Single and multi-phase).
>>>>>>>         - Configurable General Purpose Output Signals (GPO).
>>>>>>>
>>>>>>> The LP87565-Q1 variant device uses two 2-phase outputs configuration,
>>>>>>> Buck0 is master for Buck0/1 output and Buck2 is master for Buck2/3
>>>>>>> output.
>>>>>>>
>>>>>>> Signed-off-by: Keerthy <j-keerthy@...com>
>>>>>>> ---
>>>>>>>  Documentation/devicetree/bindings/mfd/lp87565.txt |  44 ++++
>>>>>>>  drivers/mfd/Kconfig                               |  14 ++
>>>>>>>  drivers/mfd/Makefile                              |   1 +
>>>>>>>  drivers/mfd/lp87565.c                             | 103 ++++++++
>>>>>>>  include/linux/mfd/lp87565.h                       | 275 ++++++++++++++++++++++
>>>>>>>  5 files changed, 437 insertions(+)
>>>>>>>  create mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt
>>>>>>>  create mode 100644 drivers/mfd/lp87565.c
>>>>>>>  create mode 100644 include/linux/mfd/lp87565.h
>>>>>>>
>>>>
>>>> [...]
>>>>
>>>>>>> +/*
>>>>>>> + * Copyright (C) 2017 Texas Instruments Incorporated - http://www.ti.com/
>>>>>>> + *
>>>>>>> + * Author: Keerthy <j-keerthy@...com>
>>>>>>
>>>>>> We usually ask for full "first last" names.
>>>>>
>>>>> Keerthy is my full name and i do not have a surname.
>>>>
>>>> What is the 'J' for in your email address?
>>>
>>> Father's initials.
>>
>> Okay.
>>
>>>> [...]
>>>>
>>>>>>> +static const struct i2c_device_id lp87565_id_table[] = {
>>>>>>> +	{ "lp87565-q1", 0 },
>>>>>>> +	{ },
>>>>>>> +};
>>>>>>> +MODULE_DEVICE_TABLE(i2c, lp87565_id_table);
>>>>>>
>>>>>> Is this an OF only driver, or not?
>>>>
>>>> You didn't answer my question?
>>>
>>> Sorry i replied on top again. It will be an OF only driver.
>>
>> Okay, then you don't need this table and you should depend on OF in
>> the Kconfig file.
> 
> Okay. Cool thanks for this info.
> 
> I am seeing this commit: 4895e493f91bff7f96f328b883c7f6448aa6abc6
> 
> mfd: Export OF module alias information in missing drivers
> 
> So no need of i2c_device_id for any of the OF-only mfd drivers?

Referred drivers/mfd/max77686.c driver. Used probe_new. Posted v2.

> 
>>