linux-kernel - Re: [PATCH 1/2] crypto: engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1495551126.2093.60.camel@perches.com>
Date:   Tue, 23 May 2017 07:52:06 -0700
From:   Joe Perches <joe@...ches.com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>,
        herbert@...dor.apana.org.au, davem@...emloft.net
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] crypto: engine - replace pr_xxx by dev_xxx

On Tue, 2017-05-23 at 14:09 +0200, Corentin Labbe wrote:
> By adding a struct device *dev to struct engine, we could store the
> device used at register time and so use all dev_xxx functions instead of
> pr_xxx.

trivia:

> diff --git a/include/crypto/engine.h b/include/crypto/engine.h
[]
> @@ -58,6 +58,7 @@ struct crypto_engine {
>  	struct list_head	list;
>  	spinlock_t		queue_lock;
>  	struct crypto_queue	queue;
> +	struct device *dev;

Probably nicer to align to column for consistency

	struct device		*dev;