linux-kernel - Re: [PATCH 0/5] kernfs: add exportfs operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170523151334.GB6123@smirco-mbp.DHCP.thefacebook.com>
Date:   Tue, 23 May 2017 08:13:35 -0700
From:   Shaohua Li <shli@...com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     <linux-kernel@...r.kernel.org>, <tj@...nel.org>,
        <gregkh@...uxfoundation.org>, <viro@...iv.linux.org.uk>,
        <Kernel-team@...com>
Subject: Re: [PATCH 0/5] kernfs: add exportfs operations

On Tue, May 23, 2017 at 12:39:41AM -0700, Christoph Hellwig wrote:
> On Mon, May 22, 2017 at 03:53:04PM -0700, Shaohua Li wrote:
> > Hi,
> > 
> > The goal isn't to export kernfs to NFS. The intention is to make tracing cgroup
> > aware. To do this, tracing will record an id for cgroup and use the id to find
> > cgroup name later. The best id is the cgroup directory inode number. Further to
> > filter out stale cgroup directory, fhandle is the best to identify a cgroup. So
> > this is what this series try to do.
> 
> Eww.  Even if you need to maintain i_generation for that please don't
> add the full export_operations.  People will just get stupid ideas based
> on that.

Hi Christoph,
what did you mean 'don't add the full export_operations'? I'd love to change
this if there is better identification for a cgroup other than fhandle.

Thanks,
Shaohua