linux-kernel - Re: [PATCH 00/13] Linksys WRT3200ACM (Rango) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mva3wqci.fsf@free-electrons.com>
Date:   Tue, 23 May 2017 17:22:05 +0200
From:   Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:     Ralph Sennhauser <ralph.sennhauser@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Imre Kaloz <kaloz@...nwrt.org>,
        Jason Cooper <jason@...edaemon.net>,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/13] Linksys WRT3200ACM (Rango) support

Hi Ralph,
 
 On dim., mai 21 2017, Ralph Sennhauser <ralph.sennhauser@...il.com> wrote:

> Hi everyone
>
> This series adds support for the latest model in Linksys WRT AC series
> of routers. The WRT3200ACM was released in October 2016 and the code
> name is Rango.
>
> As it comes with a flash chip twice as big the dts Imre Kaloz has
> written for OpenWrt isn't based on armada-385-linksys.dtsi to avoid
> conflicts. Nonetheless its part of the same family, so the bigger part
> of this series is dedicated to reorganize / modernize / cleanup /
> somewhat future proof the armada-385-linksys.dtsi and it's dependants so
> the dts for the Rango addition can use the same dtsi.
>
> Key differences to the earlier Armada-385 based devices in the series is
> a bigger flash chip, next generation wireless modules in the mini pcie
> slots as well as a Marvell SD8887. Finally the CPU is clocked at 1866
> GHz by default.
>
> The series depends on Linux 4.12-rc1 and is targeted for 4.13.
>
> Ralph
>
>

I applied the 11 first patches on mvebu/dt. I added the "Signed-off-by"
from Imre Kaloz <kaloz@...nwrt.org> on all of them and the "Reviewed-by"
from Andrew Lunn <andrew@...n.ch> when approriate.

I also did the following things:

> Ralph Sennhauser (13):
>   ARM: dts: armada-385-linksys: flatten dtsi
>   ARM: dts: armada-385-linksys: label nodes
Fixed typo pointed by Andrew

>   ARM: dts: armada-385-linksys: flatten dependants
Fixed typo pointed by Andrew

Something that I didn't change is the word "dependants", I don't know
what do you means exactly. But not being native speaker I maybe missed
something.

>   ARM: dts: armada-385-linksys: drop redundant properties in dependants
>   ARM: dts: armada-385-linksys: bm pools by label order
>   ARM: dts: armada-385-linksys: usb3 label cleanup

I applied this one because I found Ralph explanation convincing about not
modifying the ABI

>   ARM: dts: armada-385-linksys: drop leagcy DSA bindings
Fixed typo in title and commit log

>   ARM: dts: armada-385-linksys: use binary unit prefixes

As Ralph I prefer that we use normalized unit. Especially when we use
MiB or KiB then we are sure that we use a power of 2, whereas when we
see KB we don't know if it is 1024B or 1000B.

>   ARM: dts: armada-385-linksys: partition layout is board specific
>   ARM: dts: armada-385-linksys: group pins in pinctrl
>   ARM: dts: armada-385-linksys: fixup button node names

>   clk: mvebu: add support for 1866MHz variants

I didn't apply this one as it must go through the clk tree and there was
also a pending question from Andrew.

>   ARM: dts: mvebu: add support for Linksys WRT3200ACM (Rango)

For this last one do you finally agree to use "non-removable" instead of
"broken-cd" ?

Gregory

>
>  arch/arm/boot/dts/Makefile                      |   1 +
>  arch/arm/boot/dts/armada-385-linksys-caiman.dts | 187 +++++++-----
>  arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 187 +++++++-----
>  arch/arm/boot/dts/armada-385-linksys-rango.dts  | 203 +++++++++++++
>  arch/arm/boot/dts/armada-385-linksys-shelby.dts | 187 +++++++-----
>  arch/arm/boot/dts/armada-385-linksys.dtsi       | 362 ++++++++----------------
>  drivers/clk/mvebu/armada-38x.c                  |   3 +-
>  7 files changed, 695 insertions(+), 435 deletions(-)
>  create mode 100644 arch/arm/boot/dts/armada-385-linksys-rango.dts
>
> -- 
> 2.10.2
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com