linux-kernel - Re: [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular distinctions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170523155444.GE11504@windriver.com>
Date:   Tue, 23 May 2017 11:54:44 -0400
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
CC:     <linux-kernel@...r.kernel.org>,
        Tomasz Figa <tomasz.figa@...il.com>,
        Thomas Abraham <thomas.ab@...sung.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular
 distinctions

[Re: [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular distinctions] On 23/05/2017 (Tue 16:51) Krzysztof Kozlowski wrote:

> On Mon, May 22, 2017 at 10:56 PM, Paul Gortmaker
> <paul.gortmaker@...driver.com> wrote:
> > Fixups here tend to be more all over the map vs. some of the other
> > repeated/systematic ones we've seen elsewhere.
> >
> > We remove module.h from code that isn't doing anything modular at
> > all;  if they have __init sections, then replace it with init.h
> >
> > A couple drivers have module_exit() code that is essentially orphaned,
> > and so we remove that.
> >
> > There are no module_init replacements, so we have no concerns wrt.
> > initcall ordering changes as per some of the other cleanups.
> >
> > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> >
> > We also delete the MODULE_LICENSE tag etc. since all that information
> > was (or is now) contained at the top of the file in the comments.
> >
> > Cc: Tomasz Figa <tomasz.figa@...il.com>
> > Cc: Thomas Abraham <thomas.ab@...sung.com>
> > Cc: Linus Walleij <linus.walleij@...aro.org>
> > Cc: linux-samsung-soc@...r.kernel.org
> > Cc: linux-gpio@...r.kernel.org
> > Acked-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> 
> These are quite old entries of maintainers. I guess you add Cc-entries
> once per git commit but no problem - I have it from the lists.

Actually what happend is it got sent quite some time ago, but Linus
didn't merge it because he wanted some Acks[1] and a resend.  Shortly
after Sylwester provided an ack.

So with that in mind, I decided to restart with the most simple pinctrl
patches 1st, and hence it took a while to finally get back to this one
in the final series.  But I didn't want to change an ack'd patch.

Not that it matters, but just in case you were curious.

Thanks,
Paul.

[1] https://marc.info/?l=linux-kernel&m=145803185919692&w=2

> 
> Thanks, applied.
> 
> Best regards, Krzysztof