[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d07d0b1f-0038-e91d-4748-ea3e6dfb93f0@users.sourceforge.net>
Date: Tue, 23 May 2017 18:23:17 +0200
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
To: Joe Perches <joe@...ches.com>,
tipc-discussion@...ts.sourceforge.net, netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
Jon Maloy <jon.maloy@...csson.com>,
Ying Xue <ying.xue@...driver.com>,
LKML <linux-kernel@...r.kernel.org>,
kernel-janitors@...r.kernel.org
Subject: Re: tipc: Delete error messages for failed memory allocations in
three functions
> tipc_subseq_alloc does a kcalloc (memset to 0),
> half of which is immediately overwritten.
>
> In other words, don't just blindly remove stuff,
> understand what it does and improve it.
Do you suggest another specific source code transformation pattern here?
Regards,
Markus
Powered by blists - more mailing lists