linux-kernel - Re: [PATCH v2] platform/x86: ideapad-laptop: Squelch ACPI event 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VefTZv+De3TU4bQMBND5wiYNmU5AHLD+ibhS0vL7f=wAw@mail.gmail.com>
Date:   Tue, 23 May 2017 19:37:12 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Hao Wei Tee <angelsl@...elsl.xyz>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Ike Panhc <ike.pan@...onical.com>
Subject: Re: [PATCH v2] platform/x86: ideapad-laptop: Squelch ACPI event 1

On Mon, May 22, 2017 at 1:38 PM, Hao Wei Tee <angelsl@...elsl.xyz> wrote:
> Don't simply throw this to userspace via the sparse_keymap (which does not
> have a mapping for scancode 1), as this causes KEY_UNKNOWN to be emitted,
> which is a nuisance and of no use at all (it is not the right way to expose
> this ACPI event to userspace, anyway, and the original intention of the commit
> which added this (cfee5d63767b2e7997c1f36420d008abbe61565c) was only to suppress
> an unhandled event log message).
>

Pushed to testing, thanks.

> Signed-off-by: Hao Wei Tee <angelsl@...elsl.xyz>
> ---
>  drivers/platform/x86/ideapad-laptop.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 24ca9fbe31cc..998da7b4cd8e 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -810,7 +810,6 @@ static void ideapad_acpi_notify(acpi_handle handle, u32 event, void *data)
>                         case 8:
>                         case 7:
>                         case 6:
> -                       case 1:
>                                 ideapad_input_report(priv, vpc_bit);
>                                 break;
>                         case 5:
> @@ -828,6 +827,13 @@ static void ideapad_acpi_notify(acpi_handle handle, u32 event, void *data)
>                         case 0:
>                                 ideapad_check_special_buttons(priv);
>                                 break;
> +                       case 1:
> +                               /* Some IdeaPads report event 1 every ~20
> +                                * seconds while on battery power; some
> +                                * report this when changing to/from tablet
> +                                * mode. Squelch this event.
> +                                */
> +                               break;
>                         default:
>                                 pr_info("Unknown event: %lu\n", vpc_bit);
>                         }
> --
> 2.13.0
>



-- 
With Best Regards,
Andy Shevchenko