lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 May 2017 20:03:20 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org, Dmitry Torokhov <dmitry.torokhov@...il.com>, Hans de Goede <hdegoede@...hat.com>, linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...ysocki.net>, linux-acpi@...r.kernel.org, Mika Westerberg <mika.westerberg@...ux.intel.com>, Jarkko Nikula <jarkko.nikula@...ux.intel.com>, Jagadish Krishnamoorthy <jagadish.krishnamoorthy@...el.com> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Subject: [PATCH v2 05/12] gpio: acpi: Synchronize acpi_find_gpio() and acpi_gpio_count() If we pass connection ID to the both functions and at the same time acpi_can_fallback_to_crs() returns false we will get different results, i.e. the number of GPIO resources returned by acpi_gpio_count() might be not correct. Fix this by calling acpi_can_fallback_to_crs() in acpi_gpio_count() before trying to fallback. Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Tested-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com> --- drivers/gpio/gpiolib-acpi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index 0392d8ed332f..740df0e9dcb3 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -1119,6 +1119,9 @@ int acpi_gpio_count(struct device *dev, const char *con_id) struct list_head resource_list; unsigned int crs_count = 0; + if (!acpi_can_fallback_to_crs(adev, con_id)) + return count; + INIT_LIST_HEAD(&resource_list); acpi_dev_get_resources(adev, &resource_list, acpi_find_gpio_count, &crs_count); -- 2.11.0
Powered by blists - more mailing lists