lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 May 2017 20:03:18 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org, Dmitry Torokhov <dmitry.torokhov@...il.com>, Hans de Goede <hdegoede@...hat.com>, linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...ysocki.net>, linux-acpi@...r.kernel.org, Mika Westerberg <mika.westerberg@...ux.intel.com>, Jarkko Nikula <jarkko.nikula@...ux.intel.com>, Jagadish Krishnamoorthy <jagadish.krishnamoorthy@...el.com> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Subject: [PATCH v2 03/12] gpio: acpi: Do sanity check for GpioInt in acpi_find_gpio() Check that we don't ask for output direction on GpioInt resource in cases with or without _DSD defined. Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Tested-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com> Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com> --- drivers/gpio/gpiolib-acpi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index 055a8a255a40..28f35a9de86b 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -622,12 +622,12 @@ struct gpio_desc *acpi_find_gpio(struct device *dev, desc = acpi_get_gpiod_by_index(adev, NULL, idx, &info); if (IS_ERR(desc)) return desc; + } - if ((flags == GPIOD_OUT_LOW || flags == GPIOD_OUT_HIGH) && - info.gpioint) { - dev_dbg(dev, "refusing GpioInt() entry when doing GPIOD_OUT_* lookup\n"); - return ERR_PTR(-ENOENT); - } + if (info.gpioint && + (flags == GPIOD_OUT_LOW || flags == GPIOD_OUT_HIGH)) { + dev_dbg(dev, "refusing GpioInt() entry when doing GPIOD_OUT_* lookup\n"); + return ERR_PTR(-ENOENT); } if (info.polarity == GPIO_ACTIVE_LOW) -- 2.11.0
Powered by blists - more mailing lists