linux-kernel - Re: [PATCH] net: ieee802154: fix potential null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1B82BF85-7AA5-4A52-B0A8-7336DE963567@holtmann.org>
Date:   Tue, 23 May 2017 11:13:35 -0700
From:   Marcel Holtmann <marcel@...tmann.org>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     Harry Morris <h.morris@...coda.com>, linuxdev@...coda.com,
        Alexander Aring <aar@...gutronix.de>,
        Stefan Schmidt <stefan@....samsung.com>,
        linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ieee802154: fix potential null pointer dereference

Hi Gustavo,

> Null check at line 918: if (!spi) {, implies spi might be NULL.
> Function spi_get_drvdata() dereference pointer spi.
> Move pointer priv assignment after the null check.
> 
> Addresses-Coverity-ID: 1408888
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
> drivers/net/ieee802154/ca8210.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel