linux-kernel - Re: [alsa-devel] [PATCH] ASoC: cht_bsw_max98090_ti: Remove unused function cht_get_codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f941eb4-04b9-89ea-a791-c65c939581cf@linux.intel.com>
Date:   Tue, 23 May 2017 12:25:17 -0700
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Matthias Kaehlcke <mka@...omium.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Yang A Fang <yang.a.fang@...el.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: cht_bsw_max98090_ti: Remove unused
 function cht_get_codec_dai()

On 5/23/17 12:05 PM, Matthias Kaehlcke wrote:
> Looks like the function has never been used since it was added by commit
> 17119a465706 ("ASoC: Intel: Add Cherrytrail & Braswell machine driver
> cht_bsw_max98090_ti"). Removing it fixes the following warning when
> building with clang:
>
> sound/soc/intel/boards/cht_bsw_max98090_ti.c:42:35: error: unused
>     function 'cht_get_codec_dai' [-Werror,-Wunused-function]

Fine but it'll have to be re-added when I finally find the time to 
support Baytrail with this driver.

>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>  sound/soc/intel/boards/cht_bsw_max98090_ti.c | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/sound/soc/intel/boards/cht_bsw_max98090_ti.c b/sound/soc/intel/boards/cht_bsw_max98090_ti.c
> index 742bc0d4e681..20755ecc7f9e 100644
> --- a/sound/soc/intel/boards/cht_bsw_max98090_ti.c
> +++ b/sound/soc/intel/boards/cht_bsw_max98090_ti.c
> @@ -39,18 +39,6 @@ struct cht_mc_private {
>  	bool ts3a227e_present;
>  };
>
> -static inline struct snd_soc_dai *cht_get_codec_dai(struct snd_soc_card *card)
> -{
> -	struct snd_soc_pcm_runtime *rtd;
> -
> -	list_for_each_entry(rtd, &card->rtd_list, list) {
> -		if (!strncmp(rtd->codec_dai->name, CHT_CODEC_DAI,
> -			     strlen(CHT_CODEC_DAI)))
> -			return rtd->codec_dai;
> -	}
> -	return NULL;
> -}
> -
>  static const struct snd_soc_dapm_widget cht_dapm_widgets[] = {
>  	SND_SOC_DAPM_HP("Headphone", NULL),
>  	SND_SOC_DAPM_MIC("Headset Mic", NULL),
>