linux-kernel - Re: [PATCH] um: add dummy ioremap and iounmap functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8de9b34-0f7c-1486-3a64-5b727cef7925@deltatee.com>
Date:   Wed, 24 May 2017 16:09:06 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     linux-kernel@...r.kernel.org,
        user-mode-linux-devel@...ts.sourceforge.net,
        Stephen Bates <sbates@...thlin.com>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>
Subject: Re: [PATCH] um: add dummy ioremap and iounmap functions



On 24/05/17 04:05 PM, Al Viro wrote:
>> I have designs to use these functions in scatterlist.c where they'd
>> almost certainly never be called on the um architecture but it does need
>> to compile.
> 
> Then make it fail there.

Ok, will do. I'll send a v2 patch shortly.

> Incidentally, s390 has ioremap() only when CONFIG_PCI is set.

Hmm, ok, I'll take a peek. The kbuild robot never reported any build
issues with that architecture. I did see exactly this on the tile
architecture which I sent another patch for (that your feedback also
applies to).

Thanks for the quick review and feedback,

Logan