linux-kernel - Re: [PATCH v3] ext4: fix quota charging for shared xattr blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170524222541.bmefxdhbdhle4in2@thunk.org>
Date:   Wed, 24 May 2017 18:25:41 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Andreas Dilger <adilger.kernel@...ger.ca>, Jan Kara <jack@...e.cz>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ext4: fix quota charging for shared xattr blocks

On Wed, May 24, 2017 at 04:35:19AM -0700, Tahsin Erdogan wrote:
> ext4_xattr_block_set() calls dquot_alloc_block() to charge for an xattr
> block when new references are made. However if dquot_initialize() hasn't
> been called on an inode, request for charging is effectively ignored
> because ext4_inode_info->i_dquot is not initialized yet.
> 
> Add dquot_initialize() to call paths that lead to ext4_xattr_block_set().
> 
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>
> Reviewed-by: Jan Kara <jack@...e.cz>

Applied, thanks.

					- Ted