linux-kernel - Re: [mfd] question about potential null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170524031933.Horde.wa-QkL1FV1tHTUxWqYOd-Ym@gator4166.hostgator.com>
Date:   Wed, 24 May 2017 03:19:33 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [mfd] question about potential null pointer dereference

Hi guys,

Quoting Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>:

> On Wed, May 24, 2017 at 08:22:58AM +0100, Lee Jones wrote:
>> On Tue, 23 May 2017, Gustavo A. R. Silva wrote:
>> > The issue here is that there is a potential NULL pointer  
>> dereference at line
>> > 37, in case function of_match_device() returns NULL.
>> >
>> > Maybe a patch like the following could be applied in order to avoid any
>> > chance of a NULL pointer dereference:
>>
>> I do not believe it's possible for of_match_device() to return NULL in
>> this case.
>>
>> However, if you wanted to submit a patch checking for it, it would not
>> be rejected.
>
> Personally I would prefer to have a NULL pointer check in there.
>

I'll send a patch shortly.

Thank you both.
--
Gustavo A. R. Silva