lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 May 2017 08:14:51 +0800 From: Leo Yan <leo.yan@...aro.org> To: Mathieu Poirier <mathieu.poirier@...aro.org> Cc: Jonathan Corbet <corbet@....net>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Liviu Dudau <liviu.dudau@....com>, Wei Xu <xuwei5@...ilicon.com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Andy Gross <andy.gross@...aro.org>, David Brown <david.brown@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Suzuki K Poulose <suzuki.poulose@....com>, "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org, Stephen Boyd <sboyd@...eaurora.org>, Mike Leach <mike.leach@...aro.org> Subject: Re: [PATCH v11 7/9] coresight: add support for CPU debug module Hi Mathieu, On Tue, May 23, 2017 at 11:39:16AM -0600, Mathieu Poirier wrote: [...] > > +static bool debug_enable; > > +module_param_named(enable, debug_enable, bool, 0600); > > +MODULE_PARM_DESC(enable, "Knob to enable debug functionality " > > + "(default is 0, which means is disabled by default)"); > > Checkpatch complains about a quoted string split across multiple > lines. You can probably removes the second one since information > about the default value is already detailed in patch 03/09. In this > case I suggest modifiying the description to: > > "Control to enable coresight CPU debug functionality" It's shame for checkpatch.pl warning. Although everytime I used script before sending out patch set, should think a bit more to handle them better. Have sent new patch set to dismiss them. Thanks, Leo Yan
Powered by blists - more mailing lists