linux-kernel - Re: [PATCH] mfd: add null check before pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170524084114.GP1594@localhost.localdomain>
Date:   Wed, 24 May 2017 09:41:14 +0100
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
CC:     Lee Jones <lee.jones@...aro.org>,
        <patches@...nsource.wolfsonmicro.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: add null check before pointer dereference

On Wed, May 24, 2017 at 03:27:31AM -0500, Gustavo A. R. Silva wrote:
> Add null check before dereferencing pointer of_id in order to avoid
> a potential NULL pointer dereference.
> 
> Addresses-Coverity-ID: 1408830
> Cc: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>

Looks good although is there not probably the same issue in
wm831x-i2c.c? Might be worth fixing up both of them.

Thanks,
Charles