linux-kernel - Re: [PATCH 2/5] pinctrl: meson-gxl: Fix typo in AO SPDIF pins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1495615334.14589.7.camel@baylibre.com>
Date:   Wed, 24 May 2017 10:42:14 +0200
From:   Jerome Brunet <jbrunet@...libre.com>
To:     Neil Armstrong <narmstrong@...libre.com>, linus.walleij@...aro.org
Cc:     linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] pinctrl: meson-gxl: Fix typo in AO SPDIF pins

On Wed, 2017-05-24 at 10:20 +0200, Neil Armstrong wrote:
> The AO SPDIF pins were incorrectly defined with the EE pin offset.
> 

Thx for catching this !
Reviewed-by: Jerome Brunet <jbrunet@...libre.com>

> Cc: Jerome Brunet <jbrunet@...libre.com>
> Fixes: b840d649f9ec ("pinctrl: meson: gxl: add spdif output pins")
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> ---
>  drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> index 9af8e6a..454d73f 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> @@ -279,8 +279,8 @@
>  static const unsigned int i2s_out_ch23_ao_pins[] = { PIN(GPIOAO_8, 0) };
>  static const unsigned int i2s_out_ch45_ao_pins[] = { PIN(GPIOAO_9, 0) };
>  
> -static const unsigned int spdif_out_ao_6_pins[]	= { PIN(GPIOAO_6,
> EE_OFF) };
> -static const unsigned int spdif_out_ao_9_pins[]	= { PIN(GPIOAO_9,
> EE_OFF) };
> +static const unsigned int spdif_out_ao_6_pins[]	= { PIN(GPIOAO_6, 0)
> };
> +static const unsigned int spdif_out_ao_9_pins[]	= { PIN(GPIOAO_9, 0)
> };
>  
>  static struct meson_pmx_group meson_gxl_periphs_groups[] = {
>  	GPIO_GROUP(GPIOZ_0, EE_OFF),