[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170524105139.xhaakdj3ztbkqrk5@dell>
Date: Wed, 24 May 2017 11:51:39 +0100
From: Lee Jones <lee.jones@...aro.org>
To: "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: wm831x: add null check before pointer dereference
On Wed, 24 May 2017, Gustavo A. R. Silva wrote:
> Add NULL check before dereferencing pointer of_id in order to avoid
> a potential NULL pointer dereference.
>
> Addresses-Coverity-ID: 1408829
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
> Changes in v2:
> Update error log and return value.
>
> drivers/mfd/wm831x-i2c.c | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks.
> diff --git a/drivers/mfd/wm831x-i2c.c b/drivers/mfd/wm831x-i2c.c
> index 781af06..bed66d8 100644
> --- a/drivers/mfd/wm831x-i2c.c
> +++ b/drivers/mfd/wm831x-i2c.c
> @@ -37,6 +37,10 @@ static int wm831x_i2c_probe(struct i2c_client *i2c,
>
> if (i2c->dev.of_node) {
> of_id = of_match_device(wm831x_of_match, &i2c->dev);
> + if (!of_id) {
> + dev_err(&i2c->dev, "Failed to match device\n");
> + return -ENODEV;
> + }
> type = (enum wm831x_parent)of_id->data;
> } else {
> type = (enum wm831x_parent)id->driver_data;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists