linux-kernel - Re: [PATCH] frv: Declare jiffies to be located in the .data section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21627.1495630434@warthog.procyon.org.uk>
Date:   Wed, 24 May 2017 13:53:54 +0100
From:   David Howells <dhowells@...hat.com>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     dhowells@...hat.com, Guenter Roeck <linux@...ck-us.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] frv: Declare jiffies to be located in the .data section

Matthias Kaehlcke <mka@...omium.org> wrote:

> Commit 7c30f352c852 ("jiffies.h: declare jiffies and jiffies_64 with
> ____cacheline_aligned_in_smp") removed a section specification from the
> jiffies declaration that caused conflicts on some platforms. Unfortunately
> this change broke the build for frv:
> 
> kernel/built-in.o: In function `__do_softirq':
> (.text+0x6460): relocation truncated to fit: R_FRV_GPREL12 against symbol
>     `jiffies' defined in *ABS* section in .tmp_vmlinux1
> kernel/built-in.o: In function `__do_softirq':
> (.text+0x6574): relocation truncated to fit: R_FRV_GPREL12 against symbol
>     `jiffies' defined in *ABS* section in .tmp_vmlinux1
> kernel/built-in.o: In function `pwq_activate_delayed_work':
> workqueue.c:(.text+0x15b9c): relocation truncated to fit: R_FRV_GPREL12 against
>     symbol `jiffies' defined in *ABS* section in .tmp_vmlinux1
> ...
> 
> Add __jiffy_arch_data to the declaration of jiffies and use it on frv to
> include the section specification. For all other platforms __jiffy_arch_data
> (currently) has no effect.
> 
> Fixes: 7c30f352c852 ("jiffies.h: declare jiffies and jiffies_64 with
> ____cacheline_aligned_in_smp")
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

Reviewed-by: David Howells <dhowells@...hat.com>