linux-kernel - RE: [PATCH] acpi: acpica: dbfileio: Use strlcpy to Copy a C-string into a sized buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 May 2017 14:15:52 +0000
From:   "Moore, Robert" <robert.moore@...el.com>
To:     Karim Eshapa <karim.eshapa@...il.com>
CC:     "Zheng, Lv" <lv.zheng@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] acpi: acpica: dbfileio: Use strlcpy to Copy a C-string
 into a sized buffer

I'm not sure that strlcpy is portable.
Bob


> -----Original Message-----
> From: Karim Eshapa [mailto:karim.eshapa@...il.com]
> Sent: Tuesday, May 23, 2017 4:26 PM
> To: Moore, Robert <robert.moore@...el.com>
> Cc: Zheng, Lv <lv.zheng@...el.com>; Wysocki, Rafael J
> <rafael.j.wysocki@...el.com>; lenb@...nel.org; linux-
> acpi@...r.kernel.org; devel@...ica.org; linux-kernel@...r.kernel.org;
> Karim Eshapa <karim.eshapa@...il.com>
> Subject: [PATCH] acpi: acpica: dbfileio: Use strlcpy to Copy a C-string
> into a sized buffer
> 
> Use strlcpy with sized buffer instead of strncpy to avoid non NUL-
> terminated source strings problems.
> 
> Signed-off-by: Karim Eshapa <karim.eshapa@...il.com>
> ---
>  drivers/acpi/acpica/dbfileio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpica/dbfileio.c
> b/drivers/acpi/acpica/dbfileio.c index 4d81ea2..f0f22f1 100644
> --- a/drivers/acpi/acpica/dbfileio.c
> +++ b/drivers/acpi/acpica/dbfileio.c
> @@ -99,7 +99,7 @@ void acpi_db_open_debug_file(char *name)
>  	}
> 
>  	acpi_os_printf("Debug output file %s opened\n", name);
> -	strncpy(acpi_gbl_db_debug_filename, name,
> +	strlcpy(acpi_gbl_db_debug_filename, name,
>  		sizeof(acpi_gbl_db_debug_filename));
>  	acpi_gbl_db_output_to_file = TRUE;
>  }
> --
> 2.7.4