linux-kernel - Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D54B0CBF.941D8%giridhar.malavali@cavium.com>
Date:   Wed, 24 May 2017 17:12:19 +0000
From:   "Malavali, Giridhar" <Giridhar.Malavali@...ium.com>
To:     Bart Van Assche <Bart.VanAssche@...disk.com>,
        "jthumshirn@...e.de" <jthumshirn@...e.de>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>,
        Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...ium.com>
Subject: Re: [PATCH] qla2xxx: don't disable a not previously enabled PCI
 device



On 5/24/17, 8:47 AM, "Bart Van Assche" <Bart.VanAssche@...disk.com> wrote:

>On Tue, 2017-05-23 at 16:50 +0200, Johannes Thumshirn wrote:
>> When pci_enable_device() or pci_enable_device_mem() fail in
>> qla2x00_probe_one() we bail out but do a call to
>> pci_disable_device(). This causes the dev_WARN_ON() in
>> pci_disable_device() to trigger, as the device wasn't enabled
>> previously.
>> 
>> So instead of taking the 'probe_out' error path we can directly return
>> *iff* one of the pci_enable_device() calls fails.
>> 
>> Additionally rename the 'probe_out' goto label's name to the more
>> descriptive 'disable_device'.
>> 
>> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
>> Fixes: e315cd28b9ef ("[SCSI] qla2xxx: Code changes for qla data
>>structure refactoring")
>
>Hello Johannes,
>
>Please consider adding a Cc: stable tag to this patch. Since otherwise
>this
>patch looks fine to me:
>
>Reviewed-by: Bart Van Assche <bart.vanassche@...disk.com>

Looks good to me. 

Reviewed-by: Giridhar Malavali <giridhar.malavali@...ium.com>