linux-kernel - RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BC567D27D6B7384F84318942321624DE3AB91DDD@hasmsx109.ger.corp.intel.com>
Date:   Wed, 24 May 2017 19:32:45 +0000
From:   "Jamet, Michael" <michael.jamet@...el.com>
To:     "Mario.Limonciello@...l.com" <Mario.Limonciello@...l.com>,
        "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "andreas.noever@...il.com" <andreas.noever@...il.com>,
        "Bernat, Yehezkel" <yehezkel.bernat@...el.com>,
        "lukas@...ner.de" <lukas@...ner.de>,
        "Levy, Amir (Jer)" <amir.jer.levy@...el.com>,
        "luto@...nel.org" <luto@...nel.org>,
        "Jared.Dominguez@...l.com" <Jared.Dominguez@...l.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware
 upgrade

> -----Original Message-----
> From: Mario.Limonciello@...l.com [mailto:Mario.Limonciello@...l.com]
> Sent: Wednesday, May 24, 2017 22:07
> To: mika.westerberg@...ux.intel.com
> Cc: gregkh@...uxfoundation.org; andreas.noever@...il.com; Jamet,
> Michael <michael.jamet@...el.com>; Bernat, Yehezkel
> <yehezkel.bernat@...el.com>; lukas@...ner.de; Levy, Amir (Jer)
> <amir.jer.levy@...el.com>; luto@...nel.org; Jared.Dominguez@...l.com;
> andriy.shevchenko@...ux.intel.com; linux-kernel@...r.kernel.org
> Subject: RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware
> upgrade
> 
> > -----Original Message-----
> > From: Mika Westerberg [mailto:mika.westerberg@...ux.intel.com]
> > Sent: Wednesday, May 24, 2017 6:11 AM
> > To: Limonciello, Mario <Mario_Limonciello@...l.com>
> > Cc: gregkh@...uxfoundation.org; andreas.noever@...il.com;
> > michael.jamet@...el.com; yehezkel.bernat@...el.com; lukas@...ner.de;
> > amir.jer.levy@...el.com; luto@...nel.org; Dominguez, Jared
> > <Jared_Dominguez@...L.com>; andriy.shevchenko@...ux.intel.com;
> linux-
> > kernel@...r.kernel.org
> > Subject: Re: [PATCH 00/24] Thunderbolt security levels and NVM
> > firmware upgrade
> >
> > On Tue, May 23, 2017 at 05:30:43PM +0000, Mario.Limonciello@...l.com
> wrote:
> > > (Sorry my email client is not going to wrap these at 80 columns)o
> >
> > That's fine. It is more readable this way :)
> >
> > > [    0.467319] pci 0000:00:1c.0: [8086:9d10] type 01 class 0x060400
> > > [    0.467389] pci 0000:00:1c.0: PME# supported from D0 D3hot D3cold
> > > [    0.467513] pci 0000:00:1c.0: System wakeup disabled by ACPI
> >
> > [...]
> >
> > > [    0.469363] pci 0000:01:00.0: [8086:1576] type 01 class 0x060400
> > > [    0.469483] pci 0000:01:00.0: supports D1 D2
> > > [    0.469484] pci 0000:01:00.0: PME# supported from D0 D1 D2 D3hot
> D3cold
> > > [    0.469570] pci 0000:01:00.0: System wakeup disabled by ACPI
> > > [    0.469609] pci 0000:00:1c.0: PCI bridge to [bus 01-39]
> > > [    0.469614] pci 0000:00:1c.0:   bridge window [mem 0xc4000000-
> 0xda0fffff]
> > > [    0.469618] pci 0000:00:1c.0:   bridge window [mem 0xa0000000-
> 0xc1ffffff
> > 64bit pref]
> > > [    0.469621] pci 0000:01:00.0: bridge configuration invalid ([bus 00-00]),
> > reconfiguring
> >
> > This is the problem. Here the PCIe upstream port (0000:01:00.0) is
> > visible to Linux but it is not fully configured by the BIOS ->
> > (primary/secondary/subordinate) is set to 0.
> 
> So at least for me the other difference between a successful run (where you
> plug in after boot instead) is that it shows up as instead:
> PCI bridge to [bus 02-39]
> 
> Same bridge window though.

I talked to our BIOS expert today. Here is his advice to debugging further:

It looks like something may have been wrong from system (BIOS, FW, others...) perspective.
On reboot need to enter EFI shell and check resources of 
pci 0000:01:00.0: bridge.
At the EFI shell, this bridge MUST be either configured or absent.

I would start this way, once we have this info, we may circle back to him and look into next debugging step.

/Michael
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.