linux-kernel - Re: [PATCH v2 1/3] iio: adc: ina2xx: Make use of attribute flags consistent on all channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170524204410.51fec937@kernel.org>
Date:   Wed, 24 May 2017 20:44:10 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Stefan Brüns <stefan.bruens@...h-aachen.de>
Cc:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Marc Titinger <mtitinger@...libre.com>
Subject: Re: [PATCH v2 1/3] iio: adc: ina2xx: Make use of attribute flags
 consistent on all channels

On Wed, 24 May 2017 02:09:05 +0200
Stefan Brüns <stefan.bruens@...h-aachen.de> wrote:

> Flags for shared channel attributes should be set on all channels of a
> channel set. I.e. SAMP_FREQUENCY and OVERSAMPLING_RATIO are set on the
> in_voltage{0,1} channels, thus should be set on in_power, in_current.
> 
> Signed-off-by: Stefan Brüns <stefan.bruens@...h-aachen.de>
Applied to the togreg branch of iio.git.

Thanks for tidying this up.

Jonathan
> ---
>  drivers/iio/adc/ina2xx-adc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index 6b588ac3130c..bba10a1b2fcb 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -442,6 +442,8 @@ static ssize_t ina2xx_shunt_resistor_store(struct device *dev,
>  	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
>  			      BIT(IIO_CHAN_INFO_SCALE) | \
>  			      BIT(IIO_CHAN_INFO_INT_TIME), \
> +	.info_mask_shared_by_dir = BIT(IIO_CHAN_INFO_SAMP_FREQ) | \
> +				   BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \
>  	.scan_index = (_index), \
>  	.scan_type = { \
>  		.sign = 'u', \