linux-kernel - Re: [PATCH] iio: hi8435: fix race between event enable and event generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1e3d8e6-742c-7aef-6f1d-1f3554f3cf66@cogentembedded.com>
Date:   Wed, 24 May 2017 22:56:43 +0300
From:   Nikita Yushchenko <nikita.yoush@...entembedded.com>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Sanchayan Maity <maitysanchayan@...il.com>,
        Gregor Boirie <gregor.boirie@...rot.com>,
        Matt Ranostay <mranostay@...il.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chris Healy <Chris.Healy@....aero>,
        Jeff White <Jeff.White@....aero>,
        Vladimir Barinov <vladimir.barinov@...entembedded.com>
Subject: Re: [PATCH] iio: hi8435: fix race between event enable and event
 generation

>> Add locking to avoid interference between reading/processing current
>> sence in event enable and event generation paths.
>>
>> Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>
> Make sense.  Could you give a little more detail on the seriousness
> of this bug?  I need to assess whether we just queue it up for the
> next merge window or push it forward quicker as a bug fix and
> whether to mark it for stable or not.
> 
> You probably have a better idea of how much it matters than I do!

Race was introduced by my previous patch, and noticed by Vladimir.
It is not in any released tree.

Possible race impact is loss of event or duplicate event.

Nikita