linux-kernel - Re: [PATCH v6 net-next 01/17] net: qualcomm: remove unnecessary includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170524.164240.135034942764405181.davem@davemloft.net>
Date:   Wed, 24 May 2017 16:42:40 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     stefan.wahren@...e.com
Cc:     linux-serial@...r.kernel.org, jslaby@...e.com,
        gregkh@...uxfoundation.org, netdev@...r.kernel.org,
        robh+dt@...nel.org, linux-kernel@...r.kernel.org, kubakici@...pl,
        mark.rutland@....com, LinoSanfilippo@....de,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v6 net-next 01/17] net: qualcomm: remove unnecessary
 includes

From: Stefan Wahren <stefan.wahren@...e.com>
Date: Wed, 24 May 2017 22:05:26 +0200 (CEST)

> AFAIK these ones above aren't necessary (no init, no kernel module,
> no kernel parameter, no kernel version) for this C file. So i will
> double check it.

You need the endianness translators like cpu_to_be32() or whatever,
so you need to figure out where you are getting that once these
explicit headers are removed.

And see, it's probably hidden inside of the private header's includes.

So we can't tell.