linux-kernel - Re: [PATCH v1 2/2] PCI: Correct PCI_STD_RESOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170524214308.GD2794@bhelgaas-glaptop.roam.corp.google.com>
Date:   Wed, 24 May 2017 16:43:08 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     linux-pci@...r.kernel.org, Douglas Lehr <dllehr@...ibm.com>,
        Milton Miller <miltonm@...ibm.com>,
        Anton Blanchard <anton@...ba.org>,
        linux-kernel@...r.kernel.org,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH v1 2/2] PCI: Correct PCI_STD_RESOURCE_END usage

On Fri, May 19, 2017 at 02:58:55PM -0500, Bjorn Helgaas wrote:
> PCI_STD_RESOURCE_END is (confusingly) the index of the last valid BAR, not
> the *number* of BARs.  To iterate through all possible BARs, we need to
> include PCI_STD_RESOURCE_END.
> 
> Fixes: 9fe373f9997b ("PCI: Increase IBM ipr SAS Crocodile BARs to at least system page size")
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

I applied both of these to pci/misc for v4.13.

> ---
>  drivers/pci/quirks.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 085fb787aa9e..16e6cd86ad71 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -304,7 +304,7 @@ static void quirk_extend_bar_to_page(struct pci_dev *dev)
>  {
>  	int i;
>  
> -	for (i = 0; i < PCI_STD_RESOURCE_END; i++) {
> +	for (i = 0; i <= PCI_STD_RESOURCE_END; i++) {
>  		struct resource *r = &dev->resource[i];
>  
>  		if (r->flags & IORESOURCE_MEM && resource_size(r) < PAGE_SIZE) {
>