lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 May 2017 14:38:29 +0900 From: Minchan Kim <minchan@...nel.org> To: Nick Desaulniers <nick.desaulniers@...il.com> Cc: md@...gle.com, mka@...omium.org, Nitin Gupta <ngupta@...are.org>, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mm/zsmalloc: fix -Wunneeded-internal-declaration warning On Tue, May 23, 2017 at 10:38:57PM -0700, Nick Desaulniers wrote: > is_first_page() is only called from the macro VM_BUG_ON_PAGE() which is > only compiled in as a runtime check when CONFIG_DEBUG_VM is set, > otherwise is checked at compile time and not actually compiled in. > > Fixes the following warning, found with Clang: > > mm/zsmalloc.c:472:12: warning: function 'is_first_page' is not needed and > will not be emitted [-Wunneeded-internal-declaration] > static int is_first_page(struct page *page) > ^ > > Signed-off-by: Nick Desaulniers <nick.desaulniers@...il.com> Acked-by: Minchan Kim <minchan@...nel.org> Thanks.
Powered by blists - more mailing lists