[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <eb86f383-3c27-2276-6213-99c5143420f5@cogentembedded.com>
Date: Thu, 25 May 2017 11:06:47 +0300
From: Nikita Yushchenko <nikita.yoush@...entembedded.com>
To: Shawn Guo <shawnguo@...nel.org>
Cc: Sascha Hauer <kernel@...gutronix.de>,
Stefan Agner <stefan@...er.ch>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Russell King <linux@...linux.org.uk>,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
Chris Healy <Chris.Healy@....aero>,
Jeff White <Jeff.White@....aero>
Subject: Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device
>> +&edma1 {
>> + status = "okay";
>> +};
>> +
>> +&dspi2 {
>
> Please keep these labelled nodes sort alphabetically.
Ok
>> + bus-num = <1>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_dspi2>;
>> + status = "okay";
>
> We usually have 'status' line at the bottom of property list.
Ok
>> + spi-num-chipselects = <2>;
>> +
>> + hi8435@1 {
>
> Node name should be something generic, while label can be specific
> model name. The following form might be better.
>
> hi8435: sensor@1
Ok
Although the same file, in lines nearby, has m25p128@0 and at93c46d@1.
Anyway let's delay this a bit, up to the reset polarity description
thing in hi8435 is resolved.
Nikita
Powered by blists - more mailing lists