lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <000501d2d533$27fe47b0$77fad710$@socionext.com>
Date:   Thu, 25 May 2017 17:44:43 +0900
From:   "Keiji Hayashibara" <hayashibara.keiji@...ionext.com>
To:     Yamada, Masahiro/山田 真弘 
        <yamada.masahiro@...ionext.com>, <wim@...ana.be>,
        <linux@...ck-us.net>
Cc:     <linux-watchdog@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <masami.hiramatsu@...aro.org>, <jaswinder.singh@...aro.org>,
        Hayashi, Kunihiko/林 邦彦 
        <hayashi.kunihiko@...ionext.com>,
        Owada, Kiyoshi/大和田 清志 
        <owada.kiyoshi@...ionext.com>
Subject: RE: [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver

Hi Yamada-san,

> > a/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > new file mode 100644
> > index 0000000..a59d1ba
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > @@ -0,0 +1,20 @@
> > +UniPhier watchdog timer controller
> > +
> > +This UniPhier watchdog timer controller must be under sysctrl compatible
> > node.
> > +
> > +Required properties:
> > +- compatible: should be "socionext,uniphier-wdt"
> > +
> > +Example:
> > +
> > +	sysctrl@...40000 {
> > +		compatible = "socionext,uniphier-ld11-sysctrl",
> > +			     "simple-mfd", "syscon";
> > +		reg = <0x61840000 0x4000>;
> > +
> > +		sys_wdt: watchdog {
> > +			compatible = "socionext,uniphier-wdt";
> > +		}
> > +
> > +		other nodes ...
> > +	};
> 
> 
> Next time, please include
> devicetree@...r.kernel.org
> (and Rob) in your CC list for binding review.
> 
> I think scripts/get_maintainer.pl will do it correctly for you.
> 

OK. I will include to CC list in next v2 patch.

> 
> 
> > +#include <linux/delay.h>
> 
> Is this used?

It is unnecessary. I will remove it.

Thanks.

-----
Best Regards,
Keiji Hayashibara


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ