[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1495710896.5393.32.camel@synopsys.com>
Date: Thu, 25 May 2017 11:14:59 +0000
From: Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To: "noamca@...lanox.com" <noamca@...lanox.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"eladkan@...lanox.com" <eladkan@...lanox.com>,
"linux-snps-arc@...ts.infradead.org"
<linux-snps-arc@...ts.infradead.org>
Subject: Re: [PATCH 10/10] ARC: [plat-eznps] Handle memory error as an
exception
Hi Noam,
On Thu, 2017-05-25 at 05:34 +0300, Noam Camus wrote:
> From: Noam Camus <noamca@...lanox.com>
>
> This commit adds the configuration CONFIG_EZNPS_MEM_ERROR.
> If set, it will cause the kernel to handle user memory error
> as a machine check exception.
> It is required in order to align the NPS simulator memory
> error handling to the one of the NPS400 real chip behavior.
>
> Signed-off-by: Elad Kanfi <eladkan@...lanox.com>
> Signed-off-by: Noam Camus <noamca@...lanox.com>
> ---
> arch/arc/kernel/entry-compact.S | 11 +++++++++++
> arch/arc/plat-eznps/Kconfig | 11 +++++++++++
> 2 files changed, 22 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arc/kernel/entry-compact.S b/arch/arc/kernel/entry-compact.S
> index f285dbb..d152d36 100644
> --- a/arch/arc/kernel/entry-compact.S
> +++ b/arch/arc/kernel/entry-compact.S
> @@ -203,6 +203,17 @@ END(handle_interrupt_level2)
> ; ---------------------------------------------
> ENTRY(mem_service)
>
> +#if defined(CONFIG_EZNPS_MEM_ERROR)
> + ; SW workaround to cover up on a difference between
> + ; NPS real chip and simulator behaviors.
> + ; NPS real chip will activate a machine check exception
> + ; in case of memory error, while the simulator will
> + ; trigger a level 2 interrupt. Therefor this code section
> + ; should be reached only in simulation mode.
> + ; DEAD END: display Regs and HALT
I'm not really buying that.
Why don't you just make simulator behaving exactly as your real chip?
Adding those stubs for some corner-cases here and there complicate code,
affect maintainability etc.
-Alexey
Powered by blists - more mailing lists